Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA591200C08 for ; Thu, 12 Jan 2017 01:28:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C8EFD160B50; Thu, 12 Jan 2017 00:28:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 43E29160B4E for ; Thu, 12 Jan 2017 01:28:49 +0100 (CET) Received: (qmail 63766 invoked by uid 500); 12 Jan 2017 00:28:48 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 63744 invoked by uid 99); 12 Jan 2017 00:28:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 00:28:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E367D313BF5; Thu, 12 Jan 2017 00:28:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0456936610813977188==" MIME-Version: 1.0 Subject: Re: Review Request 55241: Stop using os::system to validate perf event names. From: James Peach To: Benjamin Mahler , Greg Mann , Jiang Yan Xu Cc: James Peach , mesos Date: Thu, 12 Jan 2017 00:28:47 -0000 Message-ID: <20170112002847.1677.44791@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: James Peach X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/55241/ X-Sender: James Peach References: <20170106011728.19097.48978@reviews.apache.org> In-Reply-To: <20170106011728.19097.48978@reviews.apache.org> Reply-To: James Peach X-ReviewRequest-Repository: mesos archived-at: Thu, 12 Jan 2017 00:28:50 -0000 --===============0456936610813977188== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55241/ ----------------------------------------------------------- (Updated Jan. 12, 2017, 12:28 a.m.) Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu. Changes ------- Rebase and address review feedback. Bugs: MESOS-6862 https://issues.apache.org/jira/browse/MESOS-6862 Repository: mesos Description ------- Stop using os::system to validate perf event names. Diffs (updated) ----- src/linux/perf.cpp aa31982eb5358b7eafa7035f4358a88d3854755f Diff: https://reviews.apache.org/r/55241/diff/ Testing ------- `sudo make check` (Fedora 25) Thanks, James Peach --===============0456936610813977188==--