mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jiang Yan Xu <xuj...@apple.com>
Subject Re: Review Request 54712: Use the stout ELF parser to implement ldd.
Date Tue, 31 Jan 2017 22:59:32 GMT


> On Dec. 15, 2016, 6:47 a.m., Jiang Yan Xu wrote:
> > src/linux/ldd.cpp, line 50
> > <https://reviews.apache.org/r/54712/diff/1/?file=1582969#file1582969line50>
> >
> >     `s/dependencies/_dependencies/`?
> >     
> >     I would say `needed` is good variable name here but `_dependencies` and `dependency`
below is obviously a good pair.
> 
> James Peach wrote:
>     I pretty strongly disagree that `_dependencies` is a good name, but it is a pattern
that is often used in Mesos. I'll just do that.

It's a trick to name a couple of variables that mean the same thing. It's sometimes too hard
to come up with different names that all mean the same thing but also immediately distinguishable.
Even if I just use a bunch of synonyms I don't know if it's easier to tell which is which?
I don't think there's any hard and fast rule here so what would you have preferred?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54712/#review159106
-----------------------------------------------------------


On Dec. 19, 2016, 3:23 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54712/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2016, 3:23 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6588
>     https://issues.apache.org/jira/browse/MESOS-6588
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Use the stout ELF parser to implement an ldd() API that recursively
> gathers the link dependencies of a given program.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 
>   src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b 
>   src/linux/ldd.hpp PRE-CREATION 
>   src/linux/ldd.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54712/diff/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 25)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message