mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 55955: Added validation tests to ensure environment variable value is set.
Date Tue, 31 Jan 2017 19:58:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55955/#review163705
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/master_validation_tests.cpp (line 2678)
<https://reviews.apache.org/r/55955/#comment235182>

    We stopped using `Times(1)` because that is redundant. You can just do
    
    ```
    EXPECT_CALL(sched, registered(&driver, _, _));
    ```
    
    If there are more instances of that in this file, can you do a sweep in a different review?



src/tests/master_validation_tests.cpp (line 2783)
<https://reviews.apache.org/r/55955/#comment235183>

    ditto.



src/tests/master_validation_tests.cpp (lines 2819 - 2822)
<https://reviews.apache.org/r/55955/#comment235184>

    move this to #2800.


- Vinod Kone


On Jan. 28, 2017, 11:35 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55955/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-6991
>     https://issues.apache.org/jira/browse/MESOS-6991
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `value` field within `Environment::Variable` is being
> changed to `optional`, but for the time being we will
> enforce that it must be set for backward compatibility.
> This patch adds tests to ensure that environment variables
> with unset values are correctly rejected.
> 
> 
> Diffs
> -----
> 
>   src/tests/check_tests.cpp c88cd34fd214f111cff62591aa5fc03eb62567e4 
>   src/tests/health_check_tests.cpp debbd3c09b7555145aaf3f62a24d795d1423a269 
>   src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8 
>   src/tests/slave_validation_tests.cpp 5de771114982751e7796f55dcacd4384c6989efb 
> 
> Diff: https://reviews.apache.org/r/55955/diff/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --gtest_filter="*Validation*"
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message