mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jacob Janco <jjanco....@gmail.com>
Subject Re: Review Request 55852: Fixed MasterAllocatorTest/1.RebalancedForUpdatedWeights.
Date Tue, 31 Jan 2017 00:08:45 GMT


> On Jan. 30, 2017, 11:51 p.m., Jacob Janco wrote:
> > Ship It!
> 
> Jacob Janco wrote:
>     Makes sense, with batched allocation recovery and allocation can be interleaved causing
flakiness in this test.

Passed --gtest_repeat=1000


- Jacob


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55852/#review163594
-----------------------------------------------------------


On Jan. 23, 2017, 7:08 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55852/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 7:08 p.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jacob Janco.
> 
> 
> Bugs: MESOS-6904
>     https://issues.apache.org/jira/browse/MESOS-6904
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This test is broken by the batched allocation change.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_allocator_tests.cpp 996762f25453f7a8a5e0b7b97006ee2a603cf8c4 
> 
> Diff: https://reviews.apache.org/r/55852/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message