mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anand Mazumdar <an...@apache.org>
Subject Re: Review Request 55964: Updates for executor, scheduler V1 API docs.
Date Sun, 29 Jan 2017 18:46:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55964/#review163441
-----------------------------------------------------------



Looks good and thanks for the cleanup! 

Can you update the summary/description given that the diff also contains minor typo fixes
in the fetcher/quota docs.


docs/executor-http-api.md (line 36)
<https://reviews.apache.org/r/55964/#comment234895>

    hmm, wondering why the change from s/connection(s)/connection?
    
    We wanted to outline the fact that a scheduler can either send all non-subscribe calls
on one or more connections or use HTTP pipelining to send all the calls on the same connection.
This change gives the impression that we always want a client to use the latter.



docs/scheduler-http-api.md (line 37)
<https://reviews.apache.org/r/55964/#comment234897>

    Ditto as above.


- Anand Mazumdar


On Jan. 25, 2017, 11:58 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55964/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 11:58 p.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These APIs are no longer in beta. Also make various fixes and cleanups
> for grammar and writing style.
> 
> 
> Diffs
> -----
> 
>   docs/executor-http-api.md a3b8d6f7cff4f182c8fb77dc216d82eca1d30e7c 
>   docs/fetcher.md d4ffd523a0c689bdb462e934c431a38a9d8c350b 
>   docs/quota.md 0abb9ebe8e9a40c6b7201a1f0e8071b7b249a6ed 
>   docs/scheduler-http-api.md 958cfc52496b1585564e019f9ce8b06a623f2d5c 
> 
> Diff: https://reviews.apache.org/r/55964/diff/
> 
> 
> Testing
> -------
> 
> Visual inspection on GH.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message