mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.
Date Sat, 28 Jan 2017 01:12:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56037/#review163374
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Jan. 27, 2017, 12:45 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56037/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2017, 12:45 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit will bump the required CMake version on Windows from ~3.5 to
> 3.6.3, and then add a configure-time check to ensure that this is true
> before we build.
> 
> On Windows, bumping the required version is much less of a big deal than
> Unix, mainly because Windows does not have a package manager. The burden
> on developers is about the same, independent of the version, because the
> most convenient installation option is to use a `.msi`. Additionally,
> CMake is not widely used in the community, and where it is, the vast
> majority of users are building on Unix, so there are few constraints
> imposed by existing CI systems and users.
> 
> The primary reason to bump the version, though, is that the CMake
> featureset on Windows tends (consciously or not) to straggle a bit
> behind the Unix featureset, and recently it has come to our attention
> that (due to our ignorance of this issue) we have come to depend on some
> subtle features that are available on Unix, but not on Windows, until
> CMake 3.6.3.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f 
>   docs/windows.md 5a5f934180f11fd6260032551f0df65fde541218 
> 
> Diff: https://reviews.apache.org/r/56037/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message