mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 56005: Added a safety CHECK when accessing activeRoles in the master.
Date Fri, 27 Jan 2017 00:31:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56005/
-----------------------------------------------------------

Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
-------

Currently there is a use of the [] operator that is not preceded
by a CHECK that the key is contained in the map. This leads to a
hard to diagnose issue if there are bugs that violate this
assumption.


Diffs
-----

  src/master/master.cpp 0f2c7cd32161576fad742ef350dff64874b80854 

Diff: https://reviews.apache.org/r/56005/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message