mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Review Request 55968: Added TODOs to make the master code safer.
Date Thu, 26 Jan 2017 00:55:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55968/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

The executor and tasks fields in the master's structs for agents
and frameworks are publicly visible, but yet for correctness it
is required that callers made modifications through the member
functions which carry additional logic (e.g. tracking allocated
resources). The TODO here is to make these private and to provide
public views that are const.


Diffs
-----

  src/master/master.hpp 8e8a9037af11cf95961b6498540a0fd486ed091b 

Diff: https://reviews.apache.org/r/55968/diff/


Testing
-------

make check


Thanks,

Benjamin Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message