mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 55900: Improved style in `HealthChecker`.
Date Wed, 25 Jan 2017 20:33:32 GMT


> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote:
> > I remember we have special reason to use `Option<T>` here instead of `const
Option<T>&` in previous patches. @alex may remember that, or I missunderstanding
something here?

The parameter was introduced here: https://reviews.apache.org/r/51379/

I don't see this topic discussed in the review, so I'll let @alexr chime in to see if he remembers
something =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55900/#review162982
-----------------------------------------------------------


On Jan. 25, 2017, 6:15 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55900/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang, and Vinod
Kone.
> 
> 
> Bugs: MESOS-6280
>     https://issues.apache.org/jira/browse/MESOS-6280
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Marked `_taskPid` in the constructor as const, to be consistent with the
> other parameters.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.hpp 6e558f2061a9e31157c47d31cb64b3a8568aace3 
>   src/checks/health_checker.cpp 50aa2858e807b27bbab58a3618f5200cfe4eca9e 
> 
> Diff: https://reviews.apache.org/r/55900/diff/
> 
> 
> Testing
> -------
> 
> `make check` (macOS and Linux)
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message