mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 55740: Fixed unsafe usage of process pointer in loop.hpp.
Date Fri, 20 Jan 2017 10:26:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55740/#review162407
-----------------------------------------------------------


Ship it!




Agree with Ben here. I do not see how there is an actual danger from this code today. This
change future-proofs this code by raising the level of abstraction.

- Benjamin Bannier


On Jan. 20, 2017, 2:34 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55740/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 2:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Hindman, and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `loop(...)` helper spawns a libprocess actor to execute some
> lambda (in a loop, of course).  This actor is owned by the
> libprocess GC actor, but the body of the `loop` passes a copy of that
> pointer into a Future callback.  This will potentially segfault if
> the actor terminates outside of the `loop`.
> 
> Instead, the `loop` should use the `PID` of the actor.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/loop.hpp 8bd9715246e72474a35a0f1af94c8a5a3e87dd7a

> 
> Diff: https://reviews.apache.org/r/55740/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message