mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 55412: Fixed docker runtime isolator argv issue for nested container.
Date Wed, 11 Jan 2017 16:41:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55412/#review161261
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Jan. 11, 2017, 10:42 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55412/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2017, 10:42 a.m.)
> 
> 
> Review request for mesos, Avinash sridharan, Artem Harutyunyan, and Jie Yu.
> 
> 
> Bugs: MESOS-6852
>     https://issues.apache.org/jira/browse/MESOS-6852
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For the nested container with docker runtime isolator, the `argv`
> that should be appended to entrypoint[0] or cmd[0] are neglected.
> This case refers to the 2nd row of the runtime isolator logic
> table (sh=0, value=0, argv=1). This patch addresses the issue.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/runtime.cpp ccc2387346699adcfd21886674884c87bce508aa

> 
> Diff: https://reviews.apache.org/r/55412/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message