mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 54590: Removed unused peek function.
Date Wed, 11 Jan 2017 01:22:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/
-----------------------------------------------------------

(Updated Jan. 10, 2017, 5:22 p.m.)


Review request for mesos, Daniel Pravat and Joris Van Remoortere.


Changes
-------

Updated description.


Summary (updated)
-----------------

Removed unused peek function.


Repository: mesos


Description (updated)
-------

This essentially reverts the introduction of `peek` function from
0d87ec198b6f15d4e7025f82b7b9385175a10d4a. We can certainly re-introduce
it in the future, but as of now it has been sitting there for over
a year and we have no uses of it.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2 
  3rdparty/libprocess/src/io.cpp 8aa3576a11ed5e998492b4020cb37a45ec708093 
  3rdparty/libprocess/src/tests/io_tests.cpp 466e343e6d775fe09debce119eae4fc4849b7006 

Diff: https://reviews.apache.org/r/54590/diff/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message