mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 54590: Removed unused `peek` function.
Date Wed, 11 Jan 2017 01:21:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54590/#review161164
-----------------------------------------------------------


Ship it!




LGTM.

I'd mention the original review in the commit description to make tracking the history easier:
https://reviews.apache.org/r/36404/

- Joseph Wu


On Jan. 9, 2017, 6:47 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54590/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 6:47 p.m.)
> 
> 
> Review request for mesos, Daniel Pravat and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/io.hpp f5489dc66adb136d9f53f98ac64c3fbe7831a1c2

>   3rdparty/libprocess/src/io.cpp 8aa3576a11ed5e998492b4020cb37a45ec708093 
>   3rdparty/libprocess/src/tests/io_tests.cpp 466e343e6d775fe09debce119eae4fc4849b7006

> 
> Diff: https://reviews.apache.org/r/54590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message