Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F0B74200BDC for ; Wed, 14 Dec 2016 23:30:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EF510160B19; Wed, 14 Dec 2016 22:30:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 678E3160B0D for ; Wed, 14 Dec 2016 23:30:28 +0100 (CET) Received: (qmail 84107 invoked by uid 500); 14 Dec 2016 22:30:27 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84091 invoked by uid 99); 14 Dec 2016 22:30:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Dec 2016 22:30:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2ED182FD3F6; Wed, 14 Dec 2016 22:30:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1189984739220495429==" MIME-Version: 1.0 Subject: Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends. From: Neil Conway To: Michael Park Cc: Neil Conway , mesos Date: Wed, 14 Dec 2016 22:30:26 -0000 Message-ID: <20161214223026.17251.19669@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Neil Conway X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54018/ X-Sender: Neil Conway References: <20161123155234.27388.98223@reviews.apache.org> In-Reply-To: <20161123155234.27388.98223@reviews.apache.org> Reply-To: Neil Conway X-ReviewRequest-Repository: mesos archived-at: Wed, 14 Dec 2016 22:30:29 -0000 --===============1189984739220495429== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54018/ ----------------------------------------------------------- (Updated Dec. 14, 2016, 10:30 p.m.) Review request for mesos and Michael Park. Changes ------- Tweak test to use lambda instead of static function. Bugs: MESOS-6626 https://issues.apache.org/jira/browse/MESOS-6626 Repository: mesos Description ------- This requires providing `begin` and `end` member functions that return iterators in insertion order. With the new implementation of LinkedHashMap, this is easy to do. Diffs (updated) ----- 3rdparty/stout/include/stout/linkedhashmap.hpp f48cc5933f9a786be325f71c83151376d1ffe844 3rdparty/stout/tests/linkedhashmap_tests.cpp 376462d1b472586f1547512e6e0a1646c4f76a44 Diff: https://reviews.apache.org/r/54018/diff/ Testing ------- `make check` Thanks, Neil Conway --===============1189984739220495429==--