Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D293200BDB for ; Mon, 12 Dec 2016 23:04:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5BB00160B22; Mon, 12 Dec 2016 22:04:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A39EF160B1A for ; Mon, 12 Dec 2016 23:04:37 +0100 (CET) Received: (qmail 99781 invoked by uid 500); 12 Dec 2016 22:04:36 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 99758 invoked by uid 99); 12 Dec 2016 22:04:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Dec 2016 22:04:36 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A69EB2FC88B; Mon, 12 Dec 2016 22:04:35 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4136739482925735619==" MIME-Version: 1.0 Subject: Re: Review Request 54676: Fixed the environment overriding order in MesosContainerizer. From: Avinash sridharan To: Anand Mazumdar , Avinash sridharan , Qian Zhang , Gilbert Song Cc: Jie Yu , mesos Date: Mon, 12 Dec 2016 22:04:35 -0000 Message-ID: <20161212220435.17252.9351@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Avinash sridharan X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54676/ X-Sender: Avinash sridharan X-ReviewBoard-ShipIt: 1 References: <20161212215327.17252.32419@reviews.apache.org> In-Reply-To: <20161212215327.17252.32419@reviews.apache.org> Reply-To: Avinash sridharan X-ReviewRequest-Repository: mesos archived-at: Mon, 12 Dec 2016 22:04:38 -0000 --===============4136739482925735619== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54676/#review158903 ----------------------------------------------------------- Fix it, then Ship it! Ship It! src/slave/containerizer/mesos/containerizer.cpp (line 1419) s/arlier/earlier src/tests/containerizer/cni_isolator_tests.cpp (line 586) s/join/joins - Avinash sridharan On Dec. 12, 2016, 9:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54676/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 9:53 p.m.) > > > Review request for mesos, Anand Mazumdar, Avinash sridharan, Gilbert Song, and Qian Zhang. > > > Bugs: MESOS-6781 > https://issues.apache.org/jira/browse/MESOS-6781 > > > Repository: mesos > > > Description > ------- > > Fixed the environment overriding order in MesosContainerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp 747aaa840bcd9d94badad72964b506a8d43678f5 > src/tests/containerizer/cni_isolator_tests.cpp b032c4345683813bca5f9a5eec09f73d860299cc > > Diff: https://reviews.apache.org/r/54676/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > > --===============4136739482925735619==--