Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 97102200BD7 for ; Sun, 11 Dec 2016 13:24:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8987D160B20; Sun, 11 Dec 2016 12:24:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0C8E160B07 for ; Sun, 11 Dec 2016 13:24:53 +0100 (CET) Received: (qmail 4183 invoked by uid 500); 11 Dec 2016 12:24:53 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4166 invoked by uid 99); 11 Dec 2016 12:24:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 11 Dec 2016 12:24:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E6F782FAF80; Sun, 11 Dec 2016 12:24:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3190382082322841477==" MIME-Version: 1.0 Subject: Re: Review Request 54538: WIP: Enabled fine grained authorization for the getContainers API Call. From: Adam B To: Adam B Cc: mesos , Alexander Rojas Date: Sun, 11 Dec 2016 12:24:51 -0000 Message-ID: <20161211122451.17252.53245@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Adam B X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54538/ X-Sender: Adam B References: <20161209153330.15025.66974@reviews.apache.org> In-Reply-To: <20161209153330.15025.66974@reviews.apache.org> Reply-To: Adam B X-ReviewRequest-Repository: mesos archived-at: Sun, 11 Dec 2016 12:24:54 -0000 --===============3190382082322841477== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54538/#review158795 ----------------------------------------------------------- src/slave/http.cpp (line 1833) double-underscore? Do we just skip over `_containers()`? I suppose that's part of `/containers`? src/slave/http.cpp (lines 1901 - 1903) No longer necessary - Adam B On Dec. 9, 2016, 7:33 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54538/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 7:33 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Enables fine grained authorization for the v1 API call GET_CONTAINERS. > > > Diffs > ----- > > src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d > src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17 > > Diff: https://reviews.apache.org/r/54538/diff/ > > > Testing > ------- > > ** Needs more testing ** > > make check > > > Thanks, > > Alexander Rojas > > --===============3190382082322841477==--