Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 72FD6200BD3 for ; Wed, 7 Dec 2016 00:01:31 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 719F6160B2A; Tue, 6 Dec 2016 23:01:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B71C7160B1B for ; Wed, 7 Dec 2016 00:01:30 +0100 (CET) Received: (qmail 18279 invoked by uid 500); 6 Dec 2016 23:01:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 18264 invoked by uid 99); 6 Dec 2016 23:01:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2016 23:01:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 769402D9010; Tue, 6 Dec 2016 23:01:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3981689522102100770==" MIME-Version: 1.0 Subject: Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server. From: Kevin Klues To: Jie Yu Cc: Kevin Klues , mesos Date: Tue, 06 Dec 2016 23:01:24 -0000 Message-ID: <20161206230124.1678.44805@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kevin Klues X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54442/ X-Sender: Kevin Klues References: <20161206200341.1680.38554@reviews.apache.org> In-Reply-To: <20161206200341.1680.38554@reviews.apache.org> Reply-To: Kevin Klues X-ReviewRequest-Repository: mesos archived-at: Tue, 06 Dec 2016 23:01:31 -0000 --===============3981689522102100770== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54442/ ----------------------------------------------------------- (Updated Dec. 6, 2016, 11:01 p.m.) Review request for mesos and Jie Yu. Changes ------- Updated based on Jie's comments. Bugs: MESOS-6664 https://issues.apache.org/jira/browse/MESOS-6664 Repository: mesos Description ------- When receiving a SIGTERM, the io switchboard process will forcibly unblock the server from waiting on a connection before attempting to drain its `stdoutFromFd` and `stderrFromFd` file descriptors. Once these fds are drained (or they become invalid), the server will shut itself down as per the normal exit route. Diffs (updated) ----- src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6 src/slave/containerizer/mesos/io/switchboard_main.cpp aff6c2150bfe8086fd51b548cb6339acc23f78c9 Diff: https://reviews.apache.org/r/54442/diff/ Testing ------- make check The real test is encapsulated in https://reviews.apache.org/r/54367 Thanks, Kevin Klues --===============3981689522102100770==--