Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 45DB2200BCF for ; Mon, 5 Dec 2016 19:39:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 44795160B18; Mon, 5 Dec 2016 18:39:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8EC9E160B09 for ; Mon, 5 Dec 2016 19:39:51 +0100 (CET) Received: (qmail 55390 invoked by uid 500); 5 Dec 2016 18:39:50 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 55377 invoked by uid 99); 5 Dec 2016 18:39:50 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Dec 2016 18:39:50 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BA2D52DA95D; Mon, 5 Dec 2016 18:39:49 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4887041595937662339==" MIME-Version: 1.0 Subject: Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup. From: Jie Yu To: Jie Yu Cc: Kevin Klues , mesos Date: Mon, 05 Dec 2016 18:39:49 -0000 Message-ID: <20161205183949.28537.10448@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jie Yu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54352/ X-Sender: Jie Yu X-ReviewBoard-ShipIt: 1 References: <20161205071008.28537.45087@reviews.apache.org> In-Reply-To: <20161205071008.28537.45087@reviews.apache.org> Reply-To: Jie Yu X-ReviewRequest-Repository: mesos archived-at: Mon, 05 Dec 2016 18:39:52 -0000 --===============4887041595937662339== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review158033 ----------------------------------------------------------- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp (line 539) We should not capture 'this' without a defer. Either use a 'defer' here, or capture `flags.runtime_dir`. - Jie Yu On Dec. 5, 2016, 7:10 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54352/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 7:10 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6689 > https://issues.apache.org/jira/browse/MESOS-6689 > > > Repository: mesos > > > Description > ------- > > Added removal of unix domain socket path in IOSwitchboard::cleanup. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp d5211b98616e72a27ca6b472a5ee83505c227f22 > > Diff: https://reviews.apache.org/r/54352/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > > --===============4887041595937662339==--