Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EB7AD200BD2 for ; Sat, 3 Dec 2016 19:57:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EA1E4160B16; Sat, 3 Dec 2016 18:57:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EE18160B0F for ; Sat, 3 Dec 2016 19:57:45 +0100 (CET) Received: (qmail 4783 invoked by uid 500); 3 Dec 2016 18:57:44 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4762 invoked by uid 99); 3 Dec 2016 18:57:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Dec 2016 18:57:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 720AB2D92C3; Sat, 3 Dec 2016 18:57:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1687235637684326496==" MIME-Version: 1.0 Subject: Re: Review Request 54337: Fixed the attach input call validation on the agent. From: Vinod Kone To: Vinod Kone Cc: Anand Mazumdar , mesos Date: Sat, 03 Dec 2016 18:57:43 -0000 Message-ID: <20161203185743.1642.67588@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Vinod Kone X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/54337/ X-Sender: Vinod Kone References: <20161203060150.1641.20605@reviews.apache.org> In-Reply-To: <20161203060150.1641.20605@reviews.apache.org> Reply-To: Vinod Kone X-ReviewRequest-Repository: mesos archived-at: Sat, 03 Dec 2016 18:57:46 -0000 --===============1687235637684326496== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54337/#review157897 ----------------------------------------------------------- src/tests/api_tests.cpp (line 3828) hmm. InternalServerError instead of a BadRequest sounds wrong. for non-streaming requests, looks like validation error results in BadRequest(); but not so for streaming requests? - Vinod Kone On Dec. 3, 2016, 6:01 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54337/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 6:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Previously, we were validating that all records on the stream > should have 'attach_container_input.container_id' set. However, > only the first record should have it set and be of type > 'AttachContainerInput::CONTAINER_ID'. > > This also raises the question if we should perform this > validation in the handler itself for streaming requests. > > > Diffs > ----- > > src/slave/http.cpp 8b104ce9ca6e72a1e76943f0d68a0541a45e39f6 > src/slave/validation.cpp 15330ad6e63cf6adbdf36a3c1d1a60d2315ae511 > src/tests/api_tests.cpp afae6a7e0809174f48f280f170fad9315e80a906 > > Diff: https://reviews.apache.org/r/54337/diff/ > > > Testing > ------- > > make check + added test > > > Thanks, > > Anand Mazumdar > > --===============1687235637684326496==--