mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 54716: Modified the initialization logic for `network/cni` isolator.
Date Thu, 15 Dec 2016 22:05:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54716/#review159374
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/network/cni/cni.hpp (lines 126 - 129)
<https://reviews.apache.org/r/54716/#comment230357>

    I would probably use the following interface:
    ```
    static Try<hashmap<string, string>> loadNetworkConfigs(
        const string& configDir,
        const string& pluginDir);
    ```
    
    It seems weird to me to only cache 'type' of the config. I'd change the existing `networkConfigs`
to be a hashmap of name to path. And we always validate the name in the config in `prepare`.


- Jie Yu


On Dec. 13, 2016, 11:51 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54716/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2016, 11:51 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-6567
>     https://issues.apache.org/jira/browse/MESOS-6567
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the `network/cni` isolator will soon be able to
> add/modify/delete CNI configuration files without the need for agent
> restart, we are changing the initialization logic to not bail out if
> we see errors while reading a CNI configuration file or don't find a
> CNI  plugin for a given CNI configuration. If either of these errors
> occur the `network/cni` isolator would simply skip the specific CNI
> network and complete the initialization.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp b8fc755a8dd4757d904f7e97a71d3cf7f29d2033

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ddb4d33e9ecd0ffd118e8e68cb7ec90346b08049

> 
> Diff: https://reviews.apache.org/r/54716/diff/
> 
> 
> Testing
> -------
> 
> sudo make check --gtest_filter=*CNI*
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message