mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 54018: Enhanced LinkedHashMap to support `foreachpair` and friends.
Date Wed, 14 Dec 2016 22:30:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54018/
-----------------------------------------------------------

(Updated Dec. 14, 2016, 10:30 p.m.)


Review request for mesos and Michael Park.


Changes
-------

Tweak test to use lambda instead of static function.


Bugs: MESOS-6626
    https://issues.apache.org/jira/browse/MESOS-6626


Repository: mesos


Description
-------

This requires providing `begin` and `end` member functions that return
iterators in insertion order. With the new implementation of
LinkedHashMap, this is easy to do.


Diffs (updated)
-----

  3rdparty/stout/include/stout/linkedhashmap.hpp f48cc5933f9a786be325f71c83151376d1ffe844

  3rdparty/stout/tests/linkedhashmap_tests.cpp 376462d1b472586f1547512e6e0a1646c4f76a44 

Diff: https://reviews.apache.org/r/54018/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message