mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 54755: Kept the listening socket while accept is in flight.
Date Wed, 14 Dec 2016 18:21:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54755/#review159196
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/socket.hpp (line 347)
<https://reviews.apache.org/r/54755/#comment230144>

    Can we do:
    
    `std::shared_ptr<SocketImpl> self = impl->shared_from_this();`
    
    This is a common pattern we've done in the SSL code and ultimately I'd like to add an
abstraction here to help with this and it'll be easier to find this one in the future if we
do it that way.


- Benjamin Hindman


On Dec. 14, 2016, 6:12 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54755/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Joris Van Remoortere, and Kevin Klues.
> 
> 
> Bugs: MESOS-6795
>     https://issues.apache.org/jira/browse/MESOS-6795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See details in the attached ticket.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/socket.hpp 257ff3912a46b3fe0f0989cc15e2cdbd2f9e8b2e

> 
> Diff: https://reviews.apache.org/r/54755/diff/
> 
> 
> Testing
> -------
> 
> Re-run the test in https://issues.apache.org/jira/browse/MESOS-6759 many times. Without
this patch, it fails in 2 iterations. With this patch, it does not fail.
> 
> GLOG_v=1 bin/mesos-tests.sh --gtest_filter=IOSwitchboardServerTest.AttachOutput --verbose
--gtest_repeat=-1
> 
> Also make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message