mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 54570: Added comments around some health check limitations.
Date Fri, 09 Dec 2016 15:46:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54570/#review158684
-----------------------------------------------------------


Ship it!





docs/health-checks.md (line 306)
<https://reviews.apache.org/r/54570/#comment229479>

    I wonder how significant this overhead is. Do we have any profiling information we could
add to the ticket for reasoning?


- Till Toenshoff


On Dec. 9, 2016, 3:11 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54570/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 3:11 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md 9e3be78b8900143c2cbb8c970ac6acee1b3f4bb5 
>   src/health-check/health_checker.cpp c0d150a014b7debf23b58982efe335a189d32c7b 
> 
> Diff: https://reviews.apache.org/r/54570/diff/
> 
> 
> Testing
> -------
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message