mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 50415: Added build step to build Java Protobuf.
Date Thu, 08 Dec 2016 20:59:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50415/#review158565
-----------------------------------------------------------




3rdparty/CMakeLists.txt (line 310)
<https://reviews.apache.org/r/50415/#comment229349>

    I think we can probably remove this, right? (Also, if you didn't know, these variables
are all written down in `build/CMakeCache.txt` when you configure.)



3rdparty/CMakeLists.txt (line 311)
<https://reviews.apache.org/r/50415/#comment229351>

    I must be missing something, because I don't quite see why it's necessary to copy `protoc`
over to the Java root?



3rdparty/CMakeLists.txt (line 347)
<https://reviews.apache.org/r/50415/#comment229350>

    If I'm understanding this correctly, this will download a fresh copy of the protobuf tarball,
and then build only the Java parts of it.
    
    Since we're already downloading this for the normal Protobuf build, it seems like it would
be easier to get rid of the `ExternalProject_Add` call and simply append the java config,
build, and install commands to the protobuf config, build, and install commands. For example:
    
    ```
    set(PROTOBUF_BUILD_CMD ${PROTOBUF_BUILD_CMD} ${PROTOBUF_JAVA_BUILD_CMD})
    ```
    
    This should cause the normal protobuf build to build the Java stuff as well, no?


- Alex Clemmer


On Dec. 8, 2016, 6:19 p.m., Srinivas Brahmaroutu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50415/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 6:19 p.m.)
> 
> 
> Review request for mesos, Alex Clemmer and Joseph Wu.
> 
> 
> Bugs: MESOS-5902
>     https://issues.apache.org/jira/browse/MESOS-5902
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added config, build and install steps for the External project
> protobuf_java.
> 'make probuf_java' produces the
> ${PROTOBUF_JAVA_ROOT}/java/target/protobuf-java-2.6.1.jar
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt a340b29fc1cc8b68bf74bfc0c9c2274f0af84eee 
> 
> Diff: https://reviews.apache.org/r/50415/diff/
> 
> 
> Testing
> -------
> 
> cmake && make protobuf-2.6.1-java 
> check if 3rdparty/protobuf-2.6.1/src/protobuf-2.6.1-java/java/target/protobuf-java-2.6.1.jar
> 
> 
> Thanks,
> 
> Srinivas Brahmaroutu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message