mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54489: Stout: Check POSIX-standard TMPDIR before falling back to /tmp.
Date Thu, 08 Dec 2016 02:23:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54489/
-----------------------------------------------------------

(Updated Dec. 8, 2016, 2:23 a.m.)


Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Greg Mann, and Joseph Wu.


Bugs: MESOS-6717
    https://issues.apache.org/jira/browse/MESOS-6717


Repository: mesos


Description
-------

This commit will partially address MESOS-6717, specifically: the Agent
test harness's `environment.cpp` uses POSIX-specific constructs to find
a temporary directory to call `os::mkdtemp` on; since `/tmp` often does
not exist on Windows, it will cause all Agent tests to fail immediately,
because `os::mkdtemp` will fail when components of the patter do not
exist.

This commit will begin the process of moving the POSIX-specific logic
for selecting a temporary directory to `os::temp` in preparation for
removing it from `environment.cpp`.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/posix/temp.hpp 823c97b30d8d2a940b6735b6d28ba2d3614e0b98


Diff: https://reviews.apache.org/r/54489/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message