mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54442: Added SIGTERM handler to gracefully shutdown IOSwitchboard server.
Date Tue, 06 Dec 2016 23:01:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54442/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 11:01 p.m.)


Review request for mesos and Jie Yu.


Changes
-------

Updated based on Jie's comments.


Bugs: MESOS-6664
    https://issues.apache.org/jira/browse/MESOS-6664


Repository: mesos


Description
-------

When receiving a SIGTERM, the io switchboard process will forcibly
unblock the server from waiting on a connection before attempting to
drain its `stdoutFromFd` and `stderrFromFd` file descriptors. Once
these fds are drained (or they become invalid), the server will shut
itself down as per the normal exit route.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 0254bd2f37cedd90f37d7b3e38a9b47e3d0fc3a6

  src/slave/containerizer/mesos/io/switchboard_main.cpp aff6c2150bfe8086fd51b548cb6339acc23f78c9


Diff: https://reviews.apache.org/r/54442/diff/


Testing
-------

make check

The real test is encapsulated in https://reviews.apache.org/r/54367


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message