mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Review Request 54453: Transitioned to `in_memory` log as default in tests involving Master.
Date Tue, 06 Dec 2016 22:34:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54453/
-----------------------------------------------------------

Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, Joris Van Remoortere, and Joseph
Wu.


Bugs: MESOS-6695 and MESOS-6697
    https://issues.apache.org/jira/browse/MESOS-6695
    https://issues.apache.org/jira/browse/MESOS-6697


Repository: mesos


Description
-------

Currently, nearly all instances of the Master in our tests have the
`replicated_log` flag turned on. On Windows, this will cause all tests
that involve instantiating a Master to fail immediately.

This commit will solve this problem by setting the default master flags
to set `in_memory` instead, and then selectively turning on
`replicated_log` when it's necessary.

NOTE: This commit is largely a resurrection of #41665. And, although it
is meant specifically to address MESOS-6697, this issue actually affects
almost all open issues in MESOS-6695.


Diffs
-----

  src/tests/dynamic_weights_tests.cpp 6f1e249e51e41aee7fdb22a2ccbfa9be71774e6d 
  src/tests/master_tests.cpp dfedbbdf78e8054813872e9eeebccc7504097751 
  src/tests/mesos.cpp 8fd8bcb033f47e2538aa36cd373c892a882afdfd 
  src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 
  src/tests/reconciliation_tests.cpp 71073a05a702dffd4c8e10c3c125a144ac8ca41d 

Diff: https://reviews.apache.org/r/54453/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message