mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 54336: Windows: Fix `Flags::runtime_dir` value.
Date Mon, 05 Dec 2016 19:56:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54336/#review158050
-----------------------------------------------------------




src/slave/flags.cpp (lines 213 - 231)
<https://reviews.apache.org/r/54336/#comment228723>

    In general, I do question whether this should be in the CLI code. It seems like this lambda
should be wrapped up into a function, `Try<std::string> os::runstatedir` (as Jie suggests
in #54335)? Then you can `CHECK_SOME` on that result here.
    
    Just as a note, since this review is blocking the agent code working, I do think it's
fine to not have it block on the `os::var` review, and just have it return a directory in
`temp` on Windows until we sort out the issues in the `os::var` review. The questions about
what where we should put variable data on Windows is (IMO) worth considering somewhat carefully,
but they are not necessary to complete here.



src/slave/flags.cpp (line 214)
<https://reviews.apache.org/r/54336/#comment228722>

    Hmm, shouldn't this be a `Try<std::string>`?
    
    Also, in #54336 the Unix version of `os::var` is returning a `std::string`, so unless
I'm missing something important, it seems like this should actually not build on Unix?


- Alex Clemmer


On Dec. 5, 2016, 5:38 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54336/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:38 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-6677
>     https://issues.apache.org/jira/browse/MESOS-6677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The default `runtime_dir` value was POSIX specific,
> and caused https://issues.apache.org/jira/browse/MESOS-6677.
> Now uses `os::var()` to get `C:\ProgramData\mesos\runtime` for Windows
> and `/var/lib/mesos/runtime` for POSIX.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp 6c381f06365b9deb84f43cdd101a2d2e5d826f57 
>   src/slave/flags.cpp 0de15eca7da9bf8fbdbb90c6e96edfe76f4a0f44 
> 
> Diff: https://reviews.apache.org/r/54336/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message