mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Clemmer <clemmer.alexan...@gmail.com>
Subject Re: Review Request 52778: Added Windows support to Agent test environment harness.
Date Sat, 03 Dec 2016 00:06:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52778/
-----------------------------------------------------------

(Updated Dec. 3, 2016, 12:06 a.m.)


Review request for mesos, Daniel Pravat and Joseph Wu.


Repository: mesos


Description
-------

Added Windows support to Agent test harness.

Several files required to run any of the Agent tests currently can't be
compiled by MSVC. The individual reasons are mostly small, incidental
details -- missing headers, assumption of POSIX paths, and so on. The
one big exception to this is that the `main` function of the test binary
itself isn't setting up the WSA stack and making sure the right SEH
callbacks are present.

This commit addresses all of these issues.


Diffs (updated)
-----

  src/sched/sched.cpp 6a44d57ba5771568571b9bdbed3b87d0c35ff345 
  src/scheduler/scheduler.cpp d545c9f0c0f507810dd873e3e6b5a665ff7f7584 
  src/tests/containerizer.hpp 9d99ac172e5e8c27461af3ab1230f6dc9181ec7b 
  src/tests/environment.cpp 970136f98c601c4fbc71e8ffbf506bebe89c3658 
  src/tests/main.cpp e5990e2e141c188de7fe1b8d5f2d274560c04df4 
  src/tests/mock_docker.hpp a24f87c87bbfac96a123204883fb1771f6993d89 
  src/tests/utils.cpp 0a9e5a867a46795f01fcf7030f50581b5ef1341f 

Diff: https://reviews.apache.org/r/52778/diff/


Testing
-------


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message