mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 54291: Added os::ptsname to stout.
Date Fri, 02 Dec 2016 19:29:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54291/#review157800
-----------------------------------------------------------




3rdparty/stout/include/stout/posix/os.hpp (line 480)
<https://reviews.apache.org/r/54291/#comment228401>

    If I recall, there was a reason we usually only  declare static pointers (and leak memory)
instead of statically declaring actual objects, but I don't remember of the top of my head.
Joris explained it to me once.


- Kevin Klues


On Dec. 2, 2016, 6:29 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54291/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2016, 6:29 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Kevin Klues.
> 
> 
> Bugs: MESOS-6470
>     https://issues.apache.org/jira/browse/MESOS-6470
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added os::ptsname to stout.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/posix/os.hpp c37e64db662ba3cee83d2f55de0f9d71ad72c038

> 
> Diff: https://reviews.apache.org/r/54291/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message