mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Review Request 54300: Added a test for validateRoles method.
Date Fri, 02 Dec 2016 08:51:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54300/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Guangya Liu.


Bugs: MESOS-6629
    https://issues.apache.org/jira/browse/MESOS-6629


Repository: mesos


Description
-------

There are three attributes: 'role', 'roles' and MULTI_ROLE to be
validated by this method, therefore covered by 2^3 test cases.
Also the test ensures this method checks duplicate entries in 'roles'.


Diffs
-----

  src/tests/master_validation_tests.cpp 5c44967a077551944831383a6bcc6dcb1c626df9 

Diff: https://reviews.apache.org/r/54300/diff/


Testing
-------


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message