mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojian...@cn.ibm.com>
Subject Re: Review Request 54062: Introduced validateRoles method for FrameworkInfo.
Date Fri, 02 Dec 2016 08:44:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54062/
-----------------------------------------------------------

(Updated Dec. 2, 2016, 8:44 a.m.)


Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang.


Changes
-------

rebase and addresses comments from ben and guangya


Summary (updated)
-----------------

Introduced validateRoles method for FrameworkInfo.


Bugs: MESOS-6629
    https://issues.apache.org/jira/browse/MESOS-6629


Repository: mesos


Description (updated)
-------

Roles should not contain duplicate entries. Also, we need to validate
that 'role', 'roles' and MULTI_ROLE capability are set properly. They
are checked against following matrix:

-- MULTI_ROLE is NOT set --
+-------+-------+---------+
|       |Roles  |No Roles |
+-------+-------+---------+
|Role   | Error |  None   |
+-------+-------+---------+
|No Role| Error |  None   |
+-------+-------+---------+

---- MULTI_ROLE is set ----
+-------+-------+---------+
|       |Roles  |No Roles |
+-------+-------+---------+
|Role   | Error |  Error  |
+-------+-------+---------+
|No Role| None  |  None   |
+-------+-------+---------+


Diffs (updated)
-----

  src/master/validation.hpp b8389460f34b3531f2b6ff93f18f496c01e1a079 
  src/master/validation.cpp 42d9b4a8784c2a161b74d7b46619cc22272e14e3 

Diff: https://reviews.apache.org/r/54062/diff/


Testing
-------

make check


Thanks,

Jay Guo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message