Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2275B200BD0 for ; Wed, 30 Nov 2016 10:56:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 21107160B13; Wed, 30 Nov 2016 09:56:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C553160B08 for ; Wed, 30 Nov 2016 10:56:25 +0100 (CET) Received: (qmail 37434 invoked by uid 500); 30 Nov 2016 09:56:24 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37414 invoked by uid 99); 30 Nov 2016 09:56:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Nov 2016 09:56:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4573F2C8C3B; Wed, 30 Nov 2016 09:56:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3343055419718202238==" MIME-Version: 1.0 Subject: Re: Review Request 53541: Added authorization actions for Nested Container and Debug API. From: Adam B To: Kapil Arya , Adam B , Kevin Klues , Till Toenshoff Cc: Alexander Rojas , mesos Date: Wed, 30 Nov 2016 09:56:24 -0000 Message-ID: <20161130095624.1642.74595@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Adam B X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/53541/ X-Sender: Adam B X-ReviewBoard-ShipIt: 1 References: <20161129151817.5575.4288@reviews.apache.org> In-Reply-To: <20161129151817.5575.4288@reviews.apache.org> Reply-To: Adam B X-ReviewRequest-Repository: mesos archived-at: Wed, 30 Nov 2016 09:56:26 -0000 --===============3343055419718202238== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53541/#review157387 ----------------------------------------------------------- Fix it, then Ship it! Looks great! Just a few remaining nits. src/tests/authorization_tests.cpp (line 2558) s/execturos/executors/ src/tests/authorization_tests.cpp (lines 3144 - 3145) "bar" can launch nested containers under executors running as linux user "bar" src/tests/authorization_tests.cpp (line 3163) s/execturos/executors/ src/tests/authorization_tests.cpp (lines 3233 - 3234) s/no user in command/no command/ src/tests/authorization_tests.cpp (line 3376) s/cannot/can/ - Adam B On Nov. 29, 2016, 7:18 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53541/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 7:18 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Kevin Klues, and Till Toenshoff. > > > Bugs: MESOS-6474 > https://issues.apache.org/jira/browse/MESOS-6474 > > > Repository: mesos > > > Description > ------- > > Creates new authorization action for all the API's related to > nested containers. This patch does not add the code necesary to > call use those actions, this is done in a latter patch. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto e3fd6a4a1b617a75714ebd6e08ab10cffa1a7d1b > include/mesos/authorizer/authorizer.hpp 3cd0f84e25c0ea91a6f20eba26341a1b830d8cf2 > include/mesos/authorizer/authorizer.proto 0696a629ac2d2b9950e20708f0c3666b58ff7ca0 > src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198 > src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474 > > Diff: https://reviews.apache.org/r/53541/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > > --===============3343055419718202238==--