Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DAE60200BDA for ; Tue, 29 Nov 2016 00:37:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D97EF160B22; Mon, 28 Nov 2016 23:37:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2E710160B0D for ; Tue, 29 Nov 2016 00:37:23 +0100 (CET) Received: (qmail 64489 invoked by uid 500); 28 Nov 2016 23:37:22 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 64472 invoked by uid 99); 28 Nov 2016 23:37:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Nov 2016 23:37:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 27F412F53AA; Mon, 28 Nov 2016 23:37:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4658814664473960901==" MIME-Version: 1.0 Subject: Re: Review Request 50827: Windows: Disable modules tests and related helpers. From: Joseph Wu To: Daniel Pravat , Artem Harutyunyan , Joris Van Remoortere , Alex Clemmer Cc: Mesos ReviewBot , Joseph Wu , mesos Date: Mon, 28 Nov 2016 23:37:20 -0000 Message-ID: <20161128233720.5575.70203@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Joseph Wu X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50827/ X-Sender: Joseph Wu References: <20161115221646.20484.98014@reviews.apache.org> In-Reply-To: <20161115221646.20484.98014@reviews.apache.org> Reply-To: Joseph Wu X-ReviewRequest-Repository: mesos archived-at: Mon, 28 Nov 2016 23:37:24 -0000 --===============4658814664473960901== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50827/ ----------------------------------------------------------- (Updated Nov. 28, 2016, 3:37 p.m.) Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and Joris Van Remoortere. Changes ------- Rebase on new container logger tests. Bugs: MESOS-5994 https://issues.apache.org/jira/browse/MESOS-5994 Repository: mesos Description ------- Building and linking modules has some extra challenges on Windows (see MESOS-5994). This patch #ifdef's some module-specific tests on Windows. NOTE: Most module tests are already parameterized to run the same code, once as a built-in class and once as a module. Diffs (updated) ----- src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474 src/tests/container_logger_tests.cpp 6f69c08d305c971df2684db00910d485e8a38261 src/tests/cram_md5_authentication_tests.cpp 56c249f48a09e86e1652362b54dca1fea5fc448b src/tests/http_authentication_tests.cpp e73f21f7bd5ebb776ce5e950e1035182b32018ad src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 src/tests/master_authorization_tests.cpp 4712361021708fff1ebdb5fa34386196c10c838e src/tests/slave_authorization_tests.cpp b579ee9d8fefae54923cc3b202442eea43ad6639 Diff: https://reviews.apache.org/r/50827/diff/ Testing ------- make check (OSX) TODO: Test this on Linux and Windows. Thanks, Joseph Wu --===============4658814664473960901==--