mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 52696: Harden stout
Date Wed, 30 Nov 2016 17:10:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52696/
-----------------------------------------------------------

(Updated Nov. 30, 2016, 5:10 p.m.)


Review request for mesos, James Peach, Michael Park, and Neil Conway.


Changes
-------

Fixed newline issue in the macro.


Bugs: MESOS-6229
    https://issues.apache.org/jira/browse/MESOS-6229


Repository: mesos


Description
-------

Add hardened flags for stout.
Take compile flag macro at 391cb680171d3889965b1ead43d3a326c913bc25.
The macro at 1a869696e4129279f7b99c3f9052717354b79a86 requires autoconf 2.64 which breaks
on CentOS 6.


Diffs (updated)
-----

  3rdparty/stout/Makefile.am 4e10ae2 
  3rdparty/stout/configure.ac f071f61 
  3rdparty/stout/m4/ax_check_compile_flag.m4 PRE-CREATION 

Diff: https://reviews.apache.org/r/52696/diff/


Testing
-------

Compared the benchmarks with and without the flags being used. Also did a comparsion with
the flags being used with and without optimizations and without the flags being used with
and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.


File Attachments
----------------

--enable-optimized with hardening applied
  https://reviews.apache.org/media/uploaded/files/2016/11/02/18a2f590-75ad-49c5-a697-56b746f28cae__hardened-optimized.txt
Hardening applied but no --enable-optimized
  https://reviews.apache.org/media/uploaded/files/2016/11/02/a6e07766-80cc-4bd7-856d-8952cac12562__hardened-unoptimized.txt
--enable-optimized with no hardening applied
  https://reviews.apache.org/media/uploaded/files/2016/11/02/046b37a9-5aff-4543-b3bb-5ac60daaf498__optimized.txt
No hardening applied and no --enable-optimized
  https://reviews.apache.org/media/uploaded/files/2016/11/02/3baa96cf-be05-4ac0-ad4c-ef571386e8f4__unoptimized.txt


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message