mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 50827: Windows: Disable modules tests and related helpers.
Date Mon, 28 Nov 2016 23:37:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50827/
-----------------------------------------------------------

(Updated Nov. 28, 2016, 3:37 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, and Joris Van Remoortere.


Changes
-------

Rebase on new container logger tests.


Bugs: MESOS-5994
    https://issues.apache.org/jira/browse/MESOS-5994


Repository: mesos


Description
-------

Building and linking modules has some extra challenges on Windows
(see MESOS-5994).

This patch #ifdef's some module-specific tests on Windows.
NOTE: Most module tests are already parameterized to run the same code,
once as a built-in class and once as a module.


Diffs (updated)
-----

  src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474 
  src/tests/container_logger_tests.cpp 6f69c08d305c971df2684db00910d485e8a38261 
  src/tests/cram_md5_authentication_tests.cpp 56c249f48a09e86e1652362b54dca1fea5fc448b 
  src/tests/http_authentication_tests.cpp e73f21f7bd5ebb776ce5e950e1035182b32018ad 
  src/tests/main.cpp e1507bae8267a10c85e631d10f243f299ff81dc9 
  src/tests/master_authorization_tests.cpp 4712361021708fff1ebdb5fa34386196c10c838e 
  src/tests/slave_authorization_tests.cpp b579ee9d8fefae54923cc3b202442eea43ad6639 

Diff: https://reviews.apache.org/r/50827/diff/


Testing
-------

make check (OSX)

TODO: Test this on Linux and Windows.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message