mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.com>
Subject Re: Review Request 52872: Used callback instead of `send()` for health status updates.
Date Thu, 24 Nov 2016 17:46:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52872/#review156867
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On Nov. 23, 2016, 12:52 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52872/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Benjamin Mahler, Gastón Kleiman, and haosdent
huang.
> 
> 
> Bugs: MESOS-6395
>     https://issues.apache.org/jira/browse/MESOS-6395
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since HealthChecker is now used as a library only and does not live
> in a separate OS process, there is no need to use libprocess message
> sending for health status updates; a callback will do.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp eefbc0c2936eb93044c2d8a1b50155171f398562 
>   src/health-check/health_checker.hpp 837d1358e418d21536da488e4a23cbfa41db6060 
>   src/health-check/health_checker.cpp af5500be249c74a4a5e64bf38dea607173e2f998 
>   src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf 
>   src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 
> 
> Diff: https://reviews.apache.org/r/52872/diff/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/52873/.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message