mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 53610: Added health checks documentation.
Date Thu, 24 Nov 2016 15:10:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53610/#review156837
-----------------------------------------------------------


Fix it, then Ship it!




Great work Alex, love it. As others stated as well, I am not a native speaker hence my intuitions
may be off...


docs/health-checks.md (line 19)
<https://reviews.apache.org/r/53610/#comment227169>

    s/reimplement/re-implement/ ?



docs/health-checks.md (line 40)
<https://reviews.apache.org/r/53610/#comment227153>

    s/operating incorrectly/is not responsive/ ?



docs/health-checks.md (line 50)
<https://reviews.apache.org/r/53610/#comment227154>

    s/agent/agent host/ or s/agent/agent node/ ?



docs/health-checks.md (line 51)
<https://reviews.apache.org/r/53610/#comment227155>

    s/who/which/



docs/health-checks.md (line 79)
<https://reviews.apache.org/r/53610/#comment227168>

    s/occured/occurred/



docs/health-checks.md (line 143)
<https://reviews.apache.org/r/53610/#comment227165>

    s/return codes/status codes/



docs/health-checks.md (line 212)
<https://reviews.apache.org/r/53610/#comment227170>

    s/For example/As an example/ ?


- Till Toenshoff


On Nov. 24, 2016, 11:29 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53610/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2016, 11:29 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, haosdent huang, Neil Conway, and Till Toenshoff.
> 
> 
> Bugs: MESOS-5597
>     https://issues.apache.org/jira/browse/MESOS-5597
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/health-checks.md PRE-CREATION 
>   docs/home.md 71bcb3e17ffa3119269591647fc055bab58850b4 
> 
> Diff: https://reviews.apache.org/r/53610/diff/
> 
> 
> Testing
> -------
> 
> https://gist.github.com/rukletsov/7200c36b2fd1e81f78f2583e68b31fd1
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message