mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 53877: Added temporary file environment passing towards docker.
Date Wed, 23 Nov 2016 15:46:40 GMT


> On Nov. 22, 2016, 10:48 p.m., Adam B wrote:
> > src/docker/docker.cpp, lines 575-583
> > <https://reviews.apache.org/r/53877/diff/6/?file=1568712#file1568712line575>
> >
> >     Looks like you're doing the close in both the `if(write.isError())` above and
here below. You could pull it out of the if and just do it immediately after the write, regardless
of error.

Indeed - well spotted :)


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53877/#review156658
-----------------------------------------------------------


On Nov. 22, 2016, 10:01 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53877/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 10:01 p.m.)
> 
> 
> Review request for mesos, Adam B, Gastón Kleiman, Jie Yu, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-6566
>     https://issues.apache.org/jira/browse/MESOS-6566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp f03ea7fa55e976e44282503261ac50e1502592a2 
> 
> Diff: https://reviews.apache.org/r/53877/diff/
> 
> 
> Testing
> -------
> 
> ```
> $ make check
> ```
> 
> ```
> $ ./src/mesos-execute --command="sleep 200" --containerizer=docker --docker_image=alpine
--env='{"foo": "bar"}' --master=149.202.202.185:5050
> ```
> 
> ```
> $ ps aux
> root     27645  0.2  0.0 372852 30180 ?        Sl   15:50   0:00 docker -H unix:///var/run/docker.sock
run --cpu-shares 1024 --memory 134217728 --env-file /tmp/l53ILz/ktpuDS -v /tmp/mesos/slaves/91b671fd-3c83-425e-96c2-26ecdc410028-S0/frameworks/91b671fd-3c83-425e-96c2-26ecdc410028-0001/executors/test/runs/a75fc411-3d18-44f1-a562-9f759c281da0:/mnt/mesos/sandbox
--net host --entrypoint /bin/sh --name mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
alpine -c sleep 200
> ```
> 
> ```
> $ more /tmp/l53ILz/ktpuDS
> foo=bar
> MESOS_SANDBOX=/mnt/mesos/sandbox
> MESOS_CONTAINER_NAME=mesos-91b671fd-3c83-425e-96c2-26ecdc410028-S0.a75fc411-3d18-44f1-a562-9f759c281da0
> ```
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message