mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From haosdent huang <haosd...@gmail.com>
Subject Re: Review Request 53949: Added test helper to obtain unused port.
Date Wed, 23 Nov 2016 08:43:25 GMT


> On Nov. 23, 2016, 2:20 a.m., haosdent huang wrote:
> > src/tests/utils.cpp, line 82
> > <https://reviews.apache.org/r/53949/diff/5/?file=1568626#file1568626line82>
> >
> >     Should we move the comment
> >     
> >     ```
> >     // Bind to port 0 to obtain a random unused port.
> >     ```
> >     at here?
> 
> Benjamin Bannier wrote:
>     Was thinking about this as well, but went with the current form as the comment really
applies to the whole approach this helper is taking internally.

Got it, let me drop this. :)


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53949/#review156691
-----------------------------------------------------------


On Nov. 22, 2016, 3:49 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53949/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2016, 3:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and haosdent huang.
> 
> 
> Bugs: MESOS-6618
>     https://issues.apache.org/jira/browse/MESOS-6618
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test helper to obtain unused port.
> 
> 
> Diffs
> -----
> 
>   src/tests/utils.hpp 140ebaaae43b03568ec49891635f0660cdfb4c85 
>   src/tests/utils.cpp eb36616f68d81d33d4bd04a7f23295e8c7558fc8 
> 
> Diff: https://reviews.apache.org/r/53949/diff/
> 
> 
> Testing
> -------
> 
> Tested as part of https://reviews.apache.org/r/53950/.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message