mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 53997: Fix SSL downgrade pathway for temporary/persistent sockets.
Date Tue, 22 Nov 2016 22:01:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53997/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 2:01 p.m.)


Review request for mesos, Benjamin Mahler and Joris Van Remoortere.


Bugs: MESOS-6621
    https://issues.apache.org/jira/browse/MESOS-6621


Repository: mesos


Description
-------

This fixes some potential CHECK failures when a libprocess process
has (1) SSL downgrade enabled and (2) temporary and persistent
connections open with the same remote address.  The second point is
only possible if messages are to a remote address without a persistent
connection and then a persistent connection is created.

The SSL downgrade path was only checking if the address of a socket
matched when performing the downgrade.  The code must also check to
see if the socket itself matches.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 84971fa5151991c51e78abdbc736c719e30588f1 

Diff: https://reviews.apache.org/r/53997/diff/


Testing
-------

See related ticket for the clunky unit test.  Ran that test in repetition.

make check


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message