mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 53802: Eliminated an EOF race condition in libprocess SSL socket.
Date Tue, 22 Nov 2016 19:55:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53802/
-----------------------------------------------------------

(Updated Nov. 22, 2016, 7:55 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Bugs: MESOS-5966
    https://issues.apache.org/jira/browse/MESOS-5966


Repository: mesos


Description (updated)
-------

Previously, it was possible for an SSL socket to either:
1) Fail to receive an EOF if the EOF event was received when
   there was no pending recv() request.
2) Fail to receive all data sent on the sending side if an
   EOF event was received before all sent data was read.
 	
This patch eliminates these race conditions to ensure reliable
receipt of both sent data and EOFs.


Diffs
-----

  3rdparty/libprocess/src/libevent_ssl_socket.hpp acb00d41c637a318b2f16fff9e97998b9c79b809

  3rdparty/libprocess/src/libevent_ssl_socket.cpp 21f878ee81db32ad35878ec053c3f2de3637196c


Diff: https://reviews.apache.org/r/53802/diff/


Testing (updated)
-------

Testing details are found at the end of this chain.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message