mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 52645: Harden Mesos
Date Tue, 22 Nov 2016 17:47:05 GMT


> On Nov. 19, 2016, 12:52 a.m., Michael Park wrote:
> > m4/ax_check_compile_flag.m4, line 61
> > <https://reviews.apache.org/r/52645/diff/10/?file=1559579#file1559579line61>
> >
> >     This seems to introduce a new requirement of `autoconf` version 2.64 or higher.
Ran into this no CentOS 6.
> 
> Benjamin Bannier wrote:
>     This is really unfortunate, but looking at the upstream history of this file it appears
that the latest upstream version from before this new requirement was introduced (`391cb680171d3889965b1ead43d3a326c913bc25`)
does the job just as well (I checked this with . The patch introducing this new on requirement
on autoconf-2.64 (`1a869696e4129279f7b99c3f9052717354b79a86`) was just to remove some antiquated
code patterns,
>     
>         commit 1a869696e4129279f7b99c3f9052717354b79a86
>         Author: Bastien ROUCARIÈS <roucaries.bastien@gmail.com>
>         Date:   Tue Jan 6 18:53:54 2015 +0100
>         
>             Modernize ax_append_flag, ax_check_*_flag
>         
>             Use AS_VAR* macro and AS_CASE
>             
>     I suggest we go with the version from `391cb680171d3889965b1ead43d3a326c913bc25`
which requires autoconf-2.59 for now, but call this out in the commit message (SHA we took
this from, requirement to support autoconf-2.63 on centos-6.8).
>     
>     Some for the follow-up commits introducing this macro to libprocess and stout.
> 
> Benjamin Bannier wrote:
>     !fixup I check this with centos-6.8.

Thanks for checking into this! I was just going to do the same, I'll get the remaining patches
fixed up with a previous version of that macro.


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52645/#review156367
-----------------------------------------------------------


On Nov. 9, 2016, 7:37 p.m., Aaron Wood wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52645/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2016, 7:37 p.m.)
> 
> 
> Review request for mesos, James Peach, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-6229
>     https://issues.apache.org/jira/browse/MESOS-6229
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add hardened flags for Mesos.
> Take compile flag macro at 1a869696e4129279f7b99c3f9052717354b79a86.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5380cbc 
>   m4/ax_check_compile_flag.m4 PRE-CREATION 
>   src/Makefile.am 5a47c93 
> 
> Diff: https://reviews.apache.org/r/52645/diff/
> 
> 
> Testing
> -------
> 
> Compared the benchmarks with and without the flags being used. Also did a comparsion
with the flags being used with and without optimizations and without the flags being used
with and without optimizations. Overall the performance hit was very small with a 3-8% overhead
(optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower.
> 
> 
> Thanks,
> 
> Aaron Wood
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message