mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 53890: Tweaked usage of `getFramework`.
Date Mon, 21 Nov 2016 21:26:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53890/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 9:26 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Add more `getFramework` call sites.


Summary (updated)
-----------------

Tweaked usage of `getFramework`.


Bugs: MESOS-6419
    https://issues.apache.org/jira/browse/MESOS-6419


Repository: mesos


Description (updated)
-------

In a few places, calls to `getFramework` can be hoisted out of an inner
loop. This improves code clarity (as well as maybe saving a few cycles).

A call to `getFramework` can be hoisted out of an inner loop.


Diffs (updated)
-----

  src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a 

Diff: https://reviews.apache.org/r/53890/diff/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message