mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 53938: Added helper to get the io switchboard server address.
Date Mon, 21 Nov 2016 08:51:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53938/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 8:51 a.m.)


Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.


Changes
-------

Moved logic to `utils` instead of `paths` since the logic to calculate the address is contstant
and not dependant on the runtime dir.


Bugs: MESOS-6467
    https://issues.apache.org/jira/browse/MESOS-6467


Repository: mesos


Description (updated)
-------

For now, the io switchboard server will always hosted on a unix domain
socket. The path limit for a unix domain socket is 100 bytes, so we
can't just use a file in our runtime directory as the socket file we
connect to. Instead, we store the path to the socket file in our
runtime directory and read it from there.


Diffs (updated)
-----

  src/slave/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9 
  src/slave/containerizer/mesos/utils.cpp 4e2a01495909c07f320af416ff4dc59f7328c710 

Diff: https://reviews.apache.org/r/53938/diff/


Testing
-------

make


Thanks,

Kevin Klues


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message