mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 53574: Made `CommandExecutorTest.NoTransitionFromKillingToRunning` more robust.
Date Sat, 19 Nov 2016 04:03:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53574/#review156381
-----------------------------------------------------------




src/tests/command_executor_tests.cpp (lines 266 - 268)
<https://reviews.apache.org/r/53574/#comment226609>

    Fits one line?


- Alexander Rukletsov


On Nov. 8, 2016, 4 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53574/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 4 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the test use the newly introduced test helper, instead
> of the more fragile `trap` shell built-in.
> 
> 
> Diffs
> -----
> 
>   src/tests/command_executor_tests.cpp 62a09bd17152540bad658c7c3583ee7239f435f5 
> 
> Diff: https://reviews.apache.org/r/53574/diff/
> 
> 
> Testing
> -------
> 
> `make check` (macOS and Debian)
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message