mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Wood <aaron.w...@verizon.com>
Subject Re: Review Request 52886: Fix new sign comparison errors in stout produced by hardened flags
Date Fri, 18 Nov 2016 16:27:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52886/
-----------------------------------------------------------

(Updated Nov. 18, 2016, 4:27 p.m.)


Review request for mesos, James Peach, Michael Park, and Neil Conway.


Changes
-------

Addressed comment about not converting to an unsigned value.


Bugs: MESOS-6239
    https://issues.apache.org/jira/browse/MESOS-6239


Repository: mesos


Description
-------

The hardening flags produced many new sign comparison errors in stout that need to be fixed
for Mesos to compile/run.


Diffs (updated)
-----

  3rdparty/stout/tests/cache_tests.cpp 0950c85 
  3rdparty/stout/tests/flags_tests.cpp da4deb9 
  3rdparty/stout/tests/hashmap_tests.cpp 2626d67 
  3rdparty/stout/tests/hashset_tests.cpp 66e59db 
  3rdparty/stout/tests/ip_tests.cpp b5a206f 
  3rdparty/stout/tests/json_tests.cpp 2bc4c88 
  3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 
  3rdparty/stout/tests/multimap_tests.cpp 488991b 
  3rdparty/stout/tests/os/process_tests.cpp 4cb3b5f 
  3rdparty/stout/tests/os/sendfile_tests.cpp e221689 
  3rdparty/stout/tests/os/systems_tests.cpp 110ba5b 
  3rdparty/stout/tests/os_tests.cpp 0b7ee07 
  3rdparty/stout/tests/strings_tests.cpp 7dd3301 

Diff: https://reviews.apache.org/r/52886/diff/


Testing
-------

Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran make &&
make check && make bench.


Thanks,

Aaron Wood


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message