mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.
Date Thu, 17 Nov 2016 19:07:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53474/
-----------------------------------------------------------

(Updated Nov. 17, 2016, 7:07 p.m.)


Review request for mesos, Alex Clemmer and Michael Park.


Bugs: MESOS-6520
    https://issues.apache.org/jira/browse/MESOS-6520


Repository: mesos


Description (updated)
-------

Pass the error code down to the Error object explicitly, rather than
setting the per-thread error and using it implicitly.


Diffs (updated)
-----

  3rdparty/stout/include/stout/errorbase.hpp 96d395d37cdad706c2f23fdd9caeefc2a33e0541 
  3rdparty/stout/include/stout/os/posix/rmdir.hpp 5657b5a18aaedf842b7b780ea7eada73118788cb

  3rdparty/stout/include/stout/os/windows/su.hpp 777140e1139d6eeab20780e8c0d0a273ce6a8125

  3rdparty/stout/include/stout/windows/error.hpp f296b82c47ef5ae36f6e5ee4dd289cb15bd200a6

  3rdparty/stout/include/stout/windows/fs.hpp 06c46db54e8deebe5e6715d281db699f8c4c5a58 
  3rdparty/stout/include/stout/windows/os.hpp 7ca0b5dc9793369ea142684e3614e8f33cac64b6 
  3rdparty/stout/tests/error_tests.cpp 25b50141dd9bbf163aa816750210b298456740a8 

Diff: https://reviews.apache.org/r/53474/diff/


Testing
-------

make check on Fedora 24


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message