mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 53547: Fixed `operator<<` parameter naming in libprocess.
Date Wed, 16 Nov 2016 23:43:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53547/#review156149
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On Nov. 7, 2016, 9:41 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53547/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2016, 9:41 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> By convention, we use `stream` for the first parameter to ostream
> `operator<<` implementations.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/time.hpp 554b291bc03d272fc92568f44da72ca7fcfe8838

>   3rdparty/libprocess/src/time.cpp 624ebc3611901a5fb3552dbe57b55623c1e818c5 
> 
> Diff: https://reviews.apache.org/r/53547/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message