mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 53474: Support explicit error codes in ErrnoError and SocketError.
Date Wed, 16 Nov 2016 22:25:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53474/#review156121
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/stout/include/stout/errorbase.hpp (lines 51 - 55)
<https://reviews.apache.org/r/53474/#comment226265>

    Can we flip these? Above, we have the ctor that uses `errno` implicitly followed by the
one that takes an explicit error code.



3rdparty/stout/include/stout/os/posix/rmdir.hpp (line 57)
<https://reviews.apache.org/r/53474/#comment226270>

    This is great!
    
    It seems like we have more opportunities to update here:
    
    ```
    3rdparty/libprocess/src/libevent_ssl_socket.cpp
    166:      errno = ENOTCONN;
    167-      return ErrnoError();
    ```
    ```
    3rdparty/libprocess/src/poll_socket.cpp
    138-#ifdef __WINDOWS__
    139-    ::WSASetLastError(opt);
    140-#else
    141:    errno = opt;
    142-#endif
    143-
    144-    return Failure(SocketError("Failed to connect to " + stringify(to)));
    ```
    ```
    3rdparty/stout/include/stout/windows/os.hpp
    254:    errno = ENOSYS;
    255-    return ErrnoError(
    261:    errno = ENOSYS;
    262-    return ErrnoError(
    294:    errno = ECHILD;
    295-    return WindowsError(
    305:    errno = ECHILD;
    306-    return WindowsError(
    324:    errno = ECHILD;
    325-    return WindowsError(
    ```
    ```
    3rdparty/stout/include/stout/os/windows/su.hpp
    55:  SetLastError(ERROR_NOT_SUPPORTED);
    56-  return WindowsError();
    ```
    ```
    3rdparty/stout/include/stout/windows/fs.hpp
    122:    ::SetLastError(error);
    123-    return WindowsError(
    124-        "'fs::list': 'FindNextFile' failed when searching for files with "
    125-        "'pattern '" + pattern + "'");
    ```



3rdparty/stout/include/stout/windows/error.hpp (lines 108 - 110)
<https://reviews.apache.org/r/53474/#comment226266>

    I think we get these inherited from `WindowsErrorBase`, right?



3rdparty/stout/include/stout/windows/error.hpp (lines 120 - 124)
<https://reviews.apache.org/r/53474/#comment226267>

    I think we get these inherited from `WindowsErrorBase`, right?


- Michael Park


On Nov. 4, 2016, 4:03 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53474/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2016, 4:03 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-6520
>     https://issues.apache.org/jira/browse/MESOS-6520
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support explicit error codes in ErrnoError and SocketError.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/errorbase.hpp 96d395d37cdad706c2f23fdd9caeefc2a33e0541

>   3rdparty/stout/include/stout/os/posix/rmdir.hpp 5657b5a18aaedf842b7b780ea7eada73118788cb

>   3rdparty/stout/include/stout/windows/error.hpp f296b82c47ef5ae36f6e5ee4dd289cb15bd200a6

>   3rdparty/stout/tests/error_tests.cpp 25b50141dd9bbf163aa816750210b298456740a8 
> 
> Diff: https://reviews.apache.org/r/53474/diff/
> 
> 
> Testing
> -------
> 
> make check on Fedora 24
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message